Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new options to the Delimited format #3581

Merged
merged 12 commits into from
Jul 14, 2022
Merged

Add new options to the Delimited format #3581

merged 12 commits into from
Jul 14, 2022

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Jul 12, 2022 •
edited
Loading

Pull Request Description

Implements https://www.pivotaltracker.com/story/show/182662195 and https://www.pivotaltracker.com/story/show/182651884

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide dist and ./run ide watch.

@radeusgd radeusgd self-assigned this Jul 12, 2022
@radeusgd radeusgd marked this pull request as ready for review July 13, 2022 11:54
@radeusgd radeusgd requested review from 4e6 and jdunkerley as code owners July 13, 2022 11:54
@radeusgd radeusgd requested a review from hubertp July 13, 2022 11:54
jdunkerley
jdunkerley approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment.

distribution/lib/Standard/Table/0.0.0-dev/src/Io/Line_Ending_Style.enso Show resolved Hide resolved
@radeusgd radeusgd force-pushed the wip/radeusgd/delimited-custom-comment-and-lines-182662195 branch from b59cf3f to 75ebfdc Compare July 13, 2022 13:15
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Jul 13, 2022
@radeusgd radeusgd added CI: Ready to merge This PR is eligible for automatic merge and removed CI: Ready to merge This PR is eligible for automatic merge labels Jul 13, 2022
@radeusgd radeusgd force-pushed the wip/radeusgd/delimited-custom-comment-and-lines-182662195 branch 2 times, most recently from 28586cc to 18fffa8 Compare July 13, 2022 19:44
@radeusgd radeusgd force-pushed the wip/radeusgd/delimited-custom-comment-and-lines-182662195 branch from 01fad40 to b6a9ca9 Compare July 14, 2022 14:28
@mergify mergify bot merged commit 35ddd2a into develop Jul 14, 2022
@mergify mergify bot deleted the wip/radeusgd/delimited-custom-comment-and-lines-182662195 branch July 14, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley jdunkerley approved these changes

@hubertp hubertp hubertp approved these changes

@4e6 4e6 Awaiting requested review from 4e6

Assignees

@radeusgd radeusgd

Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radeusgd @hubertp @jdunkerley