-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing basic functions #3554
Implementing basic functions #3554
Conversation
865bb36
to
84c4110
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should make these member functions rather than extensions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the indent (4 spaces) needed to get this working as member functions.
@wdanilo - I believe we want these to be global static functions we can just call?
I don't believe this is currently possible but should be once here work, statics and import completed. Is that the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These work in the current form but will need review once here.
is finished.
Thanks for the review @jdunkerley, I followed your advice and modified the test 3b99fc4 as suggested. Then I tried:
That means, once @hubertp merges his changes, the PR here shall be also mergable as it is right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will try to merge once my work is done
3b99fc4
to
52f1052
Compare
Co-authored-by: Radosław Waśko <[email protected]>
Pull Request Description
The language specification suggests to add five basic functions into the standard library.
identity
,flip
,const
,curry
&uncurry
.Important Notes
The new functions are being added into existing
Function.enso
file. That may not be the best place, but it is not clear from the design spec how they are supposed to be imported. I can move them wherever needed.There is a documentation provided for each of the functions, but I am not sure how to verify it is correct. Do we generate the documentation for stdlib somehow?
Checklist
Please include the following checklist in your PR: