Fix broken AtomBenchmarks #3546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kustosz
approved these changes
Jun 23, 2022
4e6
approved these changes
Jun 23, 2022
JaroslavTulach
added
the
CI: Ready to merge
mergify
bot
deleted the
wip/jtulach/DontDependOnRangeInBenchmarks_182199750
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci no changelog needed]
Pull Request Description
AtomBenchmarksare broken since the introduction of micro distribution. The micro distribution doesn't containRangeand as such one cannot use1.up_tomethod.Important Notes
I have rewritten enso code to manual
generator. The results of the benchmark seem comparable. Executed as:Checklist
Please include the following checklist in your PR: