Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve database Table.order_by #3514

Merged
merged 7 commits into from
Jun 7, 2022
Merged

Improve database Table.order_by #3514

merged 7 commits into from
Jun 7, 2022

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Jun 7, 2022 •
edited
Loading

Pull Request Description

Implements https://www.pivotaltracker.com/story/show/182195405

Adds support for the Postgres dialect and simple case insensitive collation for SQLite.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the
    Scala,
    Java,
    and
    Rust
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide dist and ./run ide watch.

@radeusgd radeusgd self-assigned this Jun 7, 2022
@radeusgd radeusgd force-pushed the wip/radeusgd/postgres-order-by-182195405 branch from dcca186 to 54402e4 Compare June 7, 2022 10:27
@radeusgd radeusgd marked this pull request as ready for review June 7, 2022 11:06
@radeusgd radeusgd requested review from 4e6 and jdunkerley as code owners June 7, 2022 11:06
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Jun 7, 2022
@mergify mergify bot merged commit a382e0c into develop Jun 7, 2022
@mergify mergify bot deleted the wip/radeusgd/postgres-order-by-182195405 branch June 7, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@4e6 4e6 Awaiting requested review from 4e6

@hubertp hubertp Awaiting requested review from hubertp

Assignees

@radeusgd radeusgd

Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@radeusgd @jdunkerley @JaroslavTulach