Virtual Component Groups in the Hierarchical Action List (2/2) #3510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-component-groups-181865548
This reverts commit 8a82c44.
wdanilo
approved these changes
Jun 14, 2022
|
I did not check the logic. If @farmaazon is OK with it, we can merge it :) |
|
(Process note: the code-review is now Approved, therefore the PR is waiting for an Acceptance/QA Review by @farmaazon on Task https://www.pivotaltracker.com/story/show/181865548 before merge.) |
4 tasks
farmaazon
pushed a commit
that referenced
this pull request
Jun 17, 2022
Put information about Virtual Component Groups in the Hierarchical Actions List. https://www.pivotaltracker.com/story/show/181865548 - This PR implements the subtask 2 of 2 in the ["Virtual Component Groups in the Hierarchical Action List" task](https://www.pivotaltracker.com/story/show/181865548). - Note: the PR description does not include a screencast due to the changes in this PR not having any visual effect at this moment. The result of this PR's changes would be only observed in the Component Browser, but the Component Browser is not merged yet. As described in the task's Acceptance Criteria, the changes in this PR are currently only covered by tests. - Manual integration testing with the Engine showed that a response to an `executionContext/getComponentGroups` request is non-empty only after an `executionContext/executionComplete` message is received by the IDE. (See also [a discussion on Discord](https://discord.com/channels/401396655599124480/983669600854106112).) This was not known by the IDE team or documented before, and the existing code was modified to take this into account. The protocol docs are expected to be updated by the Engine team. - A list of component groups looked up in the suggestion database is cached in the node searcher as an optimization. [ci no changelog needed]
kazcw
pushed a commit
that referenced
this pull request
Jun 29, 2022
Put information about Virtual Component Groups in the Hierarchical Actions List. https://www.pivotaltracker.com/story/show/181865548 # Important Notes - This PR implements the subtask 2 of 2 in the ["Virtual Component Groups in the Hierarchical Action List" task](https://www.pivotaltracker.com/story/show/181865548). - Note: the PR description does not include a screencast due to the changes in this PR not having any visual effect at this moment. The result of this PR's changes would be only observed in the Component Browser, but the Component Browser is not merged yet. As described in the task's Acceptance Criteria, the changes in this PR are currently only covered by tests. - Manual integration testing with the Engine showed that a response to an `executionContext/getComponentGroups` request is non-empty only after an `executionContext/executionComplete` message is received by the IDE. (See also [a discussion on Discord](https://discord.com/channels/401396655599124480/983669600854106112).) This was not known by the IDE team or documented before, and the existing code was modified to take this into account. The protocol docs are expected to be updated by the Engine team. - A list of component groups looked up in the suggestion database is cached in the node searcher as an optimization. [ci no changelog needed]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Put information about Virtual Component Groups in the Hierarchical Actions List.
https://www.pivotaltracker.com/story/show/181865548
Important Notes
executionContext/getComponentGroupsrequest is non-empty only after anexecutionContext/executionCompletemessage is received by the IDE. (See also a discussion on Discord.) This was not known by the IDE team or documented before, and the existing code was modified to take this into account. The protocol docs are expected to be updated by the Engine team.[ci no changelog needed]
Checklist
Please include the following checklist in your PR:
Scala,
Java,
and
Rust
style guides.
./run ide distand./run ide watch.