Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic inference of value types when parsing table columns #3462

Merged
merged 9 commits into from
May 20, 2022
Merged

Automatic inference of value types when parsing table columns #3462

merged 9 commits into from
May 20, 2022

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented May 18, 2022 •
edited
Loading

Pull Request Description

Implements https://www.pivotaltracker.com/story/show/182199966

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH ./run dist and ./run watch.

@radeusgd radeusgd self-assigned this May 18, 2022
@radeusgd radeusgd changed the base branch from develop to wip/radeusgd/fix-dataflow-propagation-on-primitives-181652841 May 18, 2022 19:57
@radeusgd radeusgd marked this pull request as ready for review May 19, 2022 10:31
@radeusgd radeusgd requested review from 4e6 and jdunkerley as code owners May 19, 2022 10:31
@radeusgd radeusgd force-pushed the wip/radeusgd/fix-dataflow-propagation-on-primitives-181652841 branch from 5710d50 to 9877f60 Compare May 19, 2022 13:20
Base automatically changed from wip/radeusgd/fix-dataflow-propagation-on-primitives-181652841 to develop May 19, 2022 15:25
@radeusgd radeusgd force-pushed the wip/radeusgd/table-parse-auto-182199966 branch from 9cdcdd3 to b5ea4b5 Compare May 19, 2022 15:42
jdunkerley
jdunkerley requested changes May 20, 2022
View reviewed changes
Copy link
Member

@jdunkerley jdunkerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good. A few tweaks but basic design is good.

distribution/lib/Standard/Table/0.0.0-dev/src/Data/Data_Formatter.enso Outdated Show resolved Hide resolved
distribution/lib/Standard/Table/0.0.0-dev/src/Data/Data_Formatter.enso Show resolved Hide resolved
std-bits/table/src/main/java/org/enso/table/parsing/IdentityParser.java Show resolved Hide resolved
std-bits/table/src/main/java/org/enso/table/parsing/TypeInferringParser.java Outdated Show resolved Hide resolved
std-bits/table/src/main/java/org/enso/table/parsing/IncrementalDatatypeParser.java Outdated Show resolved Hide resolved
std-bits/table/src/main/java/org/enso/table/parsing/IncrementalDatatypeParser.java Outdated Show resolved Hide resolved
@radeusgd radeusgd requested a review from jdunkerley May 20, 2022 09:03
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label May 20, 2022
@mergify mergify bot merged commit ff7700e into develop May 20, 2022
@mergify mergify bot deleted the wip/radeusgd/table-parse-auto-182199966 branch May 20, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley jdunkerley approved these changes

@4e6 4e6 Awaiting requested review from 4e6

@hubertp hubertp Awaiting requested review from hubertp

@JaroslavTulach JaroslavTulach Awaiting requested review from JaroslavTulach

Assignees

@radeusgd radeusgd

Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeusgd @jdunkerley