Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fix some small things that were making capturing and using profiles more complicated than necessary. (After this is reviewed I'll PR the new interface in the design doc repo):
Profile a predefined workflow in batch mode:
./run profile --workflow=new_project --save-profile=new_project.json
In this PR:
--save-profile
now works as expected with relative paths. (The application now runs in the directory it is started from, rather than running in its npm root.)run
commands no longer use the shell to invoke their child processes, so we won't have problems with filenames containing special characters.Profile an interactive session:
./run start --profiling-level=debug -- -- --save-profile=interactive.json
Then save profile and exit with Ctrl+Alt+Q.
In this PR:
--save-profile
) torun start
; this has been broken since Proper implementation of --no-backend flag for ./run script #3426.View a profile:
./run view-profile new_project.json
In this PR:
profiling-run-graph
entry point; accepts a path to a profile file.Misc small improvements
./run lint
output is readable.Checklist
Please include the following checklist in your PR:
./run dist
and./run watch
.[ci no changelog needed]