Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert LazyBodyNode to real ones before performing (deep)Copy #3441

Merged
merged 1 commit into from
May 9, 2022

Conversation

hubertp
Copy link
Collaborator

@hubertp hubertp commented May 9, 2022

[ci no changelog needed]

Pull Request Description

Patch provided by Jaroslav, appears to fix local issues with inifite loop
introduced in #3429.
Fairly urgent since this issue currently blocks people.

Important Notes

This renders #3439 obsolete. Related to https://www.pivotaltracker.com/n/projects/2539304/stories/182024911

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH ./run dist and ./run watch.

Patch provided by Jaroslav, appears to fix local issues with inifite loop
introduced in #3429.
This renders #3439 obsolete.
@hubertp hubertp requested a review from 4e6 as a code owner May 9, 2022 12:20
@hubertp hubertp requested a review from kustosz May 9, 2022 12:20
@hubertp hubertp changed the title Fix infinite loop by doing deep copy Convert LazyBodyNode to real ones before performing (deep)Copy May 9, 2022
@radeusgd
Copy link
Member

radeusgd commented May 9, 2022

While we should probably proceed with this ASAP to avoid blocking, I think we should investigate why it kept working on the CI, given that all (?) of us were able to reproduce this locally - and if we can do something to make sure that such issues are not overlooked by the CI.

@jdunkerley
Copy link
Member

Absolutely agree with @radeusgd point we should understand why CI didn't show this issue

@hubertp hubertp added the CI: Ready to merge This PR is eligible for automatic merge label May 9, 2022
@mwu-tow mwu-tow merged commit a06f1ed into develop May 9, 2022
@mwu-tow mwu-tow deleted the wip/hubert/fix-infinite-loop-182024911 branch May 9, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants