Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Fixed rate animation loop fixes"" #3399

Merged
merged 8 commits into from
Apr 14, 2022

Conversation

wdanilo
Copy link
Member

@wdanilo wdanilo commented Apr 13, 2022

[ci no changelog needed]

This is second attempt of implementing #3396 . The previous attempt introduced regressions and was reverted.

Pull Request Description

When implementing my another task I noticed that our fixed rate animation loop is broken. When the requestAnimationFrame was not being called at the exact time, some frames could be delayed to be refreshed to the next frame. This PR fixes that and adds tests to make sure it works properly.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH ./run dist and ./run watch.

@wdanilo
Copy link
Member Author

wdanilo commented Apr 14, 2022

I'm merging it, as it was approved already by @farmaazon and @MichaelMauderer in the previous version. They are off now, and this seem to fix the issues we've got with the previous implementation.

@wdanilo wdanilo marked this pull request as ready for review April 14, 2022 13:27
wdanilo added 2 commits April 14, 2022 19:56
…ub.com:enso-org/enso into revert-3398-revert-3396-wip/wd/animation-fixes
@wdanilo wdanilo merged commit fbe28db into develop Apr 14, 2022
@wdanilo wdanilo deleted the revert-3398-revert-3396-wip/wd/animation-fixes branch April 14, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant