Revert "Revert "Fixed rate animation loop fixes"" #3399
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ci no changelog needed]
This is second attempt of implementing #3396 . The previous attempt introduced regressions and was reverted.
Pull Request Description
When implementing my another task I noticed that our fixed rate animation loop is broken. When the
requestAnimationFrame
was not being called at the exact time, some frames could be delayed to be refreshed to the next frame. This PR fixes that and adds tests to make sure it works properly.Checklist
Please include the following checklist in your PR:
./run dist
and./run watch
.