Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data analysts should be able to use Text.to_case to change the case of Text values #3302

Merged
merged 7 commits into from
Feb 28, 2022
Merged

Data analysts should be able to use Text.to_case to change the case of Text values #3302

merged 7 commits into from
Feb 28, 2022

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Feb 24, 2022 •
edited
Loading

Pull Request Description

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH ./run dist and ./run watch.

@radeusgd radeusgd force-pushed the wip/radeusgd/text-to-case-181266136 branch from 0282979 to 3740263 Compare February 28, 2022 12:11
@radeusgd radeusgd self-assigned this Feb 28, 2022
@radeusgd radeusgd marked this pull request as ready for review February 28, 2022 12:12
@jdunkerley
Copy link
Member

One minor change for a ToDo and as discussed lets add the Title defintion from UCharacter.
Otherwise LGTM

@radeusgd radeusgd requested a review from jdunkerley February 28, 2022 15:05
@radeusgd radeusgd added Category: Stdlib --breaking Important: a change that will break a public API or user-facing behaviour CI: Ready to merge This PR is eligible for automatic merge labels Feb 28, 2022
@mergify mergify bot merged commit 0d96f59 into develop Feb 28, 2022
@mergify mergify bot deleted the wip/radeusgd/text-to-case-181266136 branch February 28, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley jdunkerley approved these changes

@4e6 4e6 Awaiting requested review from 4e6

Assignees

@radeusgd radeusgd

Labels
--breaking Important: a change that will break a public API or user-facing behaviour CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeusgd @jdunkerley