Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly proccess preparations: Setting Enso version through the environment #3241

Merged
merged 27 commits into from
Feb 7, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
8ee7b95
try getting version from the env
mwu-tow Jan 18, 2022
e80c98f
wip
mwu-tow Jan 21, 2022
cb2bf5f
Add a workaround for internal dev builds regarding a rare test edge case
radeusgd Jan 28, 2022
fdc69e4
Merge branch 'develop' into wip/mwu/engine-version-from-env
mwu-tow Feb 1, 2022
a2c570a
let edition name by default be the engine version
mwu-tow Feb 1, 2022
5357f92
Move the changelog file to the repository root.
mwu-tow Feb 2, 2022
f58054c
moved stuff to 0.0.0-dev
mwu-tow Feb 2, 2022
3d5780a
Make tests compatible with internal-dev-build version
radeusgd Feb 2, 2022
6d22129
Remove obsolete internalDevelopmentBuild flag from buildinfo
radeusgd Feb 2, 2022
26f51d8
Merge remote-tracking branch 'remotes/origin/develop' into wip/mwu/en…
mwu-tow Feb 3, 2022
2a9dfcf
attempt to bump the "big number"
mwu-tow Feb 3, 2022
64b35c7
Merge branch 'develop' into wip/mwu/engine-version-from-env
mwu-tow Feb 3, 2022
c5b6f4b
missing jars
mwu-tow Feb 3, 2022
847d324
fix the engine package artifact path
mwu-tow Feb 4, 2022
55091b8
Merge remote-tracking branch 'origin/develop' into wip/mwu/engine-ver…
mwu-tow Feb 4, 2022
9b8ddfb
Fix incremental dir copy
radeusgd Feb 4, 2022
e9a0fca
WIP: fixing runtime tests with static lib version
radeusgd Feb 5, 2022
e447651
Change versions when creating a distribution
radeusgd Feb 5, 2022
f4a4071
fix edition writer
radeusgd Feb 5, 2022
9a287ea
ensure no clashes with earlier versions of SBT build script
radeusgd Feb 5, 2022
9eb7467
Merge branch 'develop' into wip/mwu/engine-version-from-env
mwu-tow Feb 6, 2022
a6dbbd5
Merge remote-tracking branch 'origin/develop' into wip/mwu/engine-ver…
mwu-tow Feb 7, 2022
eee4a4c
Remove stdlib-version-updater which thankfully is not needed anymore
radeusgd Feb 7, 2022
32edc57
prettier + one typo
mwu-tow Feb 7, 2022
ff01dfc
more descriptive engine ci names
mwu-tow Feb 7, 2022
741d127
casing
mwu-tow Feb 7, 2022
9b672fa
lower the timeout -- new CI is faster and we don't want to keep runne…
mwu-tow Feb 7, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
7 changes: 0 additions & 7 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -169,13 +169,6 @@ jobs:
sleep 1
sbt --no-colors bootstrap

- name: Update the Stdlib Version
working-directory: repo
shell: bash
run: |
sleep 1
sbt --no-colors "stdlib-version-updater/run update --no-format"

# Verify Legal Review
- name: Verify Packages
if: runner.os != 'Windows' # TODO [RW] CRLF handling in licenses task
Expand Down
7 changes: 0 additions & 7 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -133,13 +133,6 @@ jobs:
sleep 1
sbt --no-colors verifyLicensePackages

- name: Verify the Stdlib Version
working-directory: repo
shell: bash
run: |
sleep 1
sbt --no-colors "stdlib-version-updater/run check"

# Prepare distributions
- name: Build the Launcher Native Image
working-directory: repo
Expand Down
7 changes: 4 additions & 3 deletions .github/workflows/scala-new.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This is the new, in progress, Build Workflow for the Enso Engine.

name: Engine CI V2
name: Engine CI (new)

on:
push:
Expand All @@ -16,7 +16,7 @@ jobs:
- ${{ matrix.os }}
- self-hosted
- engine
timeout-minutes: 180
timeout-minutes: 90
strategy:
matrix:
# The macOS support is not yet done. For now, the GitHub-hosted runner
Expand All @@ -43,7 +43,8 @@ jobs:
uses: actions/upload-artifact@v2
with:
name: ${{ env.ENGINE_DIST_NAME }}
path: ${{ env.ENGINE_DIST_ROOT }}/${{ env.ENGINE_DIST_NAME }}.zip
# Irregular, engine is pre-zipped to avoid long paths issues of nodejs.
path: ${{ env.ENGINE_DIST_ARCHIVE }}
- name: Publish the Launcher
uses: actions/upload-artifact@v2
with:
Expand Down
7 changes: 1 addition & 6 deletions .github/workflows/scala.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Engine CI
name: Engine CI (legacy)

on:
push:
Expand Down Expand Up @@ -123,11 +123,6 @@ jobs:
sleep 1
sbt --no-colors bootstrap

- name: Verify the Stdlib Version
run: |
sleep 1
sbt --no-colors "stdlib-version-updater/run check"

# Compile
- name: Build Enso
run: |
Expand Down
File renamed without changes.
58 changes: 37 additions & 21 deletions build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,22 @@ import java.io.File
// === Global Configuration ===================================================
// ============================================================================

val scalacVersion = "2.13.7"
val graalVersion = "21.1.0"
val javaVersion = "11"
val ensoVersion = "0.2.32-SNAPSHOT" // Note [Engine And Launcher Version]
val currentEdition = "2021.20-SNAPSHOT" // Note [Default Editions]
val stdLibVersion = ensoVersion
val scalacVersion = "2.13.7"
val graalVersion = "21.1.0"
val javaVersion = "11"
val defaultDevEnsoVersion = "0.0.0-dev"
val ensoVersion = sys.env.getOrElse(
"ENSO_VERSION",
defaultDevEnsoVersion
) // Note [Engine And Launcher Version]
val currentEdition = sys.env.getOrElse(
"ENSO_EDITION",
defaultDevEnsoVersion
) // Note [Default Editions]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose, the Default Editions note should be also updated


// Note [Stdlib Version]
val stdLibVersion = defaultDevEnsoVersion
val targetStdlibVersion = ensoVersion

/* Note [Engine And Launcher Version]
* ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Expand All @@ -44,6 +54,16 @@ val stdLibVersion = ensoVersion
* release.
*/

/* Note [Stdlib Version]
* ~~~~~~~~~~~~~~~~~~~~~
* The `stdlibVersion` variable stores the version at which standard library is
* stored within the source tree, which is currently set to a constant of
* `0.0.0-dev`.
*
* When distributions are built, the library versions are updated to match the
* current Enso version.
*/

ThisBuild / organization := "org.enso"
ThisBuild / scalaVersion := scalacVersion

Expand Down Expand Up @@ -247,7 +267,6 @@ lazy val enso = (project in file("."))
`library-manager`,
`library-manager-test`,
`connected-lock-manager`,
`stdlib-version-updater`,
syntax.jvm,
testkit
)
Expand Down Expand Up @@ -748,8 +767,7 @@ lazy val `version-output` = (project in file("lib/scala/version-output"))
ensoVersion = ensoVersion,
scalacVersion = scalacVersion,
graalVersion = graalVersion,
currentEdition = currentEdition,
stdLibVersion = stdLibVersion
currentEdition = currentEdition
)
}.taskValue
)
Expand Down Expand Up @@ -1378,6 +1396,7 @@ lazy val editions = project
.dependsOn(
Def.task {
Editions.writeEditionConfig(
editionsRoot = file("distribution") / "editions",
ensoVersion = ensoVersion,
editionName = currentEdition,
libraryVersion = stdLibVersion,
Expand Down Expand Up @@ -1470,13 +1489,6 @@ lazy val `connected-lock-manager` = project
.dependsOn(`polyglot-api`)
.dependsOn(testkit % Test)

lazy val `stdlib-version-updater` = project
.in(file("lib/scala/stdlib-version-updater"))
.configs(Test)
.dependsOn(`version-output`)
.dependsOn(pkg)
.dependsOn(cli)

lazy val `runtime-version-manager` = project
.in(file("lib/scala/runtime-version-manager"))
.configs(Test)
Expand Down Expand Up @@ -1710,11 +1722,15 @@ buildEngineDistribution := {
val log = streams.value.log
val cacheFactory = streams.value.cacheStoreFactory
DistributionPackage.createEnginePackage(
distributionRoot = root,
cacheFactory = cacheFactory,
graalVersion = graalVersion,
javaVersion = javaVersion,
stdlibVersion = stdLibVersion
distributionRoot = root,
cacheFactory = cacheFactory,
log = log,
graalVersion = graalVersion,
javaVersion = javaVersion,
ensoVersion = ensoVersion,
editionName = currentEdition,
sourceStdlibVersion = stdLibVersion,
targetStdlibVersion = targetStdlibVersion
)
log.info(s"Engine package created at $root")
}
Expand Down
2 changes: 1 addition & 1 deletion build/release.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const yaml = require('js-yaml')
const config = yaml.load(fss.readFileSync(path.join(paths.gui.root, 'config.yaml'), 'utf-8'))

const CHANGELOG_FILE_NAME = 'CHANGELOG.md'
const CHANGELOG_FILE = path.join(paths.gui.root, CHANGELOG_FILE_NAME)
const CHANGELOG_FILE = path.join(paths.root, CHANGELOG_FILE_NAME)
const ENGINE_VERSION = config.engineVersionSupported

// ===============
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Base
namespace: Standard
version: 0.2.32-SNAPSHOT
version: 0.0.0-dev
license: APLv2
authors:
- name: Enso Team
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Database
namespace: Standard
version: 0.2.32-SNAPSHOT
version: 0.0.0-dev
license: APLv2
authors:
- name: Enso Team
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Examples
namespace: Standard
version: 0.2.32-SNAPSHOT
version: 0.0.0-dev
license: APLv2
authors:
- name: Enso Team
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Geo
namespace: Standard
version: 0.2.32-SNAPSHOT
version: 0.0.0-dev
license: APLv2
authors:
- name: Enso Team
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Google_Api
namespace: Standard
version: 0.2.32-SNAPSHOT
version: 0.0.0-dev
license: APLv2
authors:
- name: Enso Team
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Image
namespace: Standard
version: 0.2.32-SNAPSHOT
version: 0.0.0-dev
license: APLv2
authors:
- name: Enso Team
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Base
namespace: Standard
version: 0.2.32-SNAPSHOT
version: 0.0.0-dev
license: APLv2
authors:
- name: Enso Team
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Table
namespace: Standard
version: 0.2.32-SNAPSHOT
version: 0.0.0-dev
license: APLv2
authors:
- name: Enso Team
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Test
namespace: Standard
version: 0.2.32-SNAPSHOT
version: 0.0.0-dev
license: APLv2
authors:
- name: Enso Team
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Visualization
namespace: Standard
version: 0.2.32-SNAPSHOT
version: 0.0.0-dev
license: APLv2
authors:
- name: Enso Team
Expand Down
Loading