Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving distinct to Map #3229

Merged
merged 11 commits into from
Jan 25, 2022
Merged

Moving distinct to Map #3229

merged 11 commits into from
Jan 25, 2022

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Jan 19, 2022

Pull Request Description

Changing the implementation of Vector.distinct to be based off the Enso map class.

Initial QA process of the previous implementation highlighted differences in equality comparison in Enso and polyglot functions (HashMap in this case). By moving to a Map based implementation the Enso based equality is used.

It also allows for use of bespoke types which have comparison operators.

Important Notes

  • No change to the public API of distinct

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@jdunkerley jdunkerley force-pushed the wip/jd/map-distinct-180899205 branch from e8a42fe to a69366c Compare January 20, 2022 14:43
@jdunkerley jdunkerley marked this pull request as ready for review January 21, 2022 14:50
@jdunkerley jdunkerley requested a review from 4e6 as a code owner January 21, 2022 14:50
@jdunkerley jdunkerley requested a review from radeusgd January 21, 2022 14:50
Copy link
Contributor

@farmaazon farmaazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just caught as a CHANGELOG owner.

@jdunkerley jdunkerley merged commit 8387375 into develop Jan 25, 2022
@jdunkerley jdunkerley deleted the wip/jd/map-distinct-180899205 branch January 25, 2022 09:57
@jdunkerley jdunkerley restored the wip/jd/map-distinct-180899205 branch January 25, 2022 10:10
@jdunkerley jdunkerley deleted the wip/jd/map-distinct-180899205 branch January 25, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants