-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving distinct to Map #3229
Merged
Merged
Moving distinct to Map #3229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
reviewed
Jan 20, 2022
distribution/lib/Standard/Base/0.2.32-SNAPSHOT/src/Data/Vector.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Base/0.2.32-SNAPSHOT/src/Data/Vector.enso
Outdated
Show resolved
Hide resolved
Still an issue with `Integer` in the mixed vector test
jdunkerley
force-pushed
the
wip/jd/map-distinct-180899205
branch
from
January 20, 2022 14:43
e8a42fe
to
a69366c
Compare
radeusgd
reviewed
Jan 21, 2022
distribution/lib/Standard/Base/0.2.32-SNAPSHOT/src/Data/Time/Duration.enso
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Jan 21, 2022
distribution/lib/Standard/Base/0.2.32-SNAPSHOT/src/Data/Vector.enso
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Jan 21, 2022
distribution/lib/Standard/Base/0.2.32-SNAPSHOT/src/Data/Vector.enso
Outdated
Show resolved
Hide resolved
radeusgd
approved these changes
Jan 21, 2022
4e6
approved these changes
Jan 24, 2022
jdunkerley
requested review from
farmaazon,
MichaelMauderer,
mwu-tow and
wdanilo
as code owners
January 24, 2022 15:38
farmaazon
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just caught as a CHANGELOG owner.
wdanilo
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Changing the implementation of
Vector.distinct
to be based off the Enso map class.Initial QA process of the previous implementation highlighted differences in equality comparison in Enso and polyglot functions (HashMap in this case). By moving to a
Map
based implementation the Enso based equality is used.It also allows for use of bespoke types which have comparison operators.
Important Notes
distinct
Checklist
Please include the following checklist in your PR: