Redshift Connector #1985
Merged
Redshift Connector #1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
requested changes
Sep 1, 2021
| @@ -0,0 +1 @@ | |||
| regarding copyright ownership. The ASF licenses this file | |||
There was a problem hiding this comment.
This is wrong. It is some random line out of context.
It was probably saved using "Keep" while "Keep with context" should have been used. In some situations "Keep in context" cannot be used, so you need to do "Ignore" and manually add the text including all relevant context to copyright-add file. As explained in the license review process docs:
...ndard/Database/0.2.28-SNAPSHOT/THIRD-PARTY/org.apache.httpcomponents.httpcore-4.4.13/NOTICES
Outdated
Show resolved
Hide resolved
radeusgd
approved these changes
Sep 1, 2021
…if not the whole universe as we know it
radeusgd
approved these changes
Sep 1, 2021
4e6
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Adds DB connector for redshift.
Important Notes
This is not automatically tested. A ticket for tests is #1984
Checklist
Please include the following checklist in your PR: