Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Spreadsheet Reading #1976

Merged
merged 12 commits into from
Sep 3, 2021
Merged

Google Spreadsheet Reading #1976

merged 12 commits into from
Sep 3, 2021

Conversation

kustosz
Copy link
Contributor

@kustosz kustosz commented Aug 27, 2021

Pull Request Description

Rudimentary ability to read Google Spreadsheets. Mostly PRed to just get a scaffolding into the repo.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@kustosz kustosz marked this pull request as ready for review September 2, 2021 11:28
Comment on lines 49 to 50
- secret_file: a file containing Google Service Account credentials to use to
access Google services.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the expected format for the credentials?

import Standard.Google_Api
import Standard.Test

main = Test.Suite.run_main <|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably make this pending if it isn't on CI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in a separate project, so just don't run it if you don't want to :P

@kustosz kustosz merged commit a81257b into main Sep 3, 2021
@kustosz kustosz deleted the wip/mk/gdoc branch September 3, 2021 19:41
iamrecursion pushed a commit that referenced this pull request Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-highest Should be completed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants