Implement library/preinstall (Without Dependencies Yet)
#1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
added
Category: Backend
-tooling
radeusgd
requested review from
4e6,
kustosz and
iamrecursion
and removed request for
4e6 and
kustosz
4e6
reviewed
Aug 26, 2021
...e/language-server/src/main/scala/org/enso/languageserver/runtime/RuntimeRequestHandler.scala
Outdated
Show resolved
Hide resolved
kustosz
approved these changes
Aug 26, 2021
...e/language-server/src/main/scala/org/enso/languageserver/runtime/RuntimeRequestHandler.scala
Outdated
Show resolved
Hide resolved
iamrecursion
approved these changes
Aug 26, 2021
radeusgd
force-pushed
the
wip/rw/library-preinstall-without-deps
branch
from
382b813
to
aa33eb2
Compare
iamrecursion
approved these changes
Aug 27, 2021
...rver/src/main/scala/org/enso/languageserver/libraries/handler/LibraryPreinstallHandler.scala
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/Language.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #1890
Implements the
library/preinstallendpoint, but for now does not try to download dependencies of the preinstalled library, only just the library itself.The endpoint itself is a few lines of code plus some tests, the biggest part of this PR is infrastructure for sharing lock management between the runtime and the language-server managing it. The issue is that file locks cannot be used to synchronize threads of a single JVM instance (as they are of the same process), but the runtime and language-server are separated by the classpath isolation, so they cannot simply share a common LockManager instance. Instead, the runtime creates a LockManager which sends requests to a primary instance managed by the language-server using the runtime server connection. For this to work, the runtime server connection had to be made bi-directional, in the sense that not only can the language-server sent requests to the runtime, but also the runtime can send requests to the language-server now.
Important Notes
Checklist
Please include the following checklist in your PR: