Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting and Setting Library Metadata #1967

Merged
merged 8 commits into from
Aug 20, 2021
Merged

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Aug 19, 2021

Pull Request Description

Implements the endpoint for getting library metadata, extending it with the ability to also fetch metadata for published libraries.

As it was needed for better testing, the endpoint setting metadata is also implemented.

Important Notes

  • It changes the API, but since it was not yet being used, it is not marked as a breaking change.
  • While such possibility is advertised in the documentation, the endpoint does not look for cached manifests of published libraries. That is because manifest caching is not yet implemented - once caching is implemented (probably around Downloading and Installing Libraries in the Package Manager #1772 when dependency downloading will be implemented), this should also be added.
  • It also updates the API of library/create to use a Contact type for authors and maintainers, as the original API was not compatible with the config format - by mistake. Since this endpoint is not yet being used, the change also should not be breaking.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@radeusgd radeusgd self-assigned this Aug 19, 2021
@radeusgd radeusgd added Category: Backend p-high Should be completed in the next sprint labels Aug 19, 2021
@radeusgd radeusgd merged commit 8cef409 into main Aug 20, 2021
@radeusgd radeusgd deleted the wip/rw/fetch-library-metadata branch August 20, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-high Should be completed in the next sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants