Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying a cell range when reading spreadsheets #1954

Merged
merged 3 commits into from
Aug 16, 2021
Merged

Allow specifying a cell range when reading spreadsheets #1954

merged 3 commits into from
Aug 16, 2021

Conversation

kustosz
Copy link
Contributor

@kustosz kustosz commented Aug 16, 2021

Pull Request Description

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@kustosz kustosz added Type: Enhancement --breaking Important: a change that will break a public API or user-facing behaviour p-highest Should be completed ASAP labels Aug 16, 2021
@kustosz kustosz requested a review from 4e6 as a code owner August 16, 2021 12:24
@kustosz kustosz self-assigned this Aug 16, 2021
radeusgd
radeusgd approved these changes Aug 16, 2021
View reviewed changes
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kustosz kustosz merged commit 98eab28 into main Aug 16, 2021
@kustosz kustosz deleted the wip/mk/spreadsheet_range branch August 16, 2021 15:01
iamrecursion pushed a commit that referenced this pull request Aug 18, 2021
@kustosz @iamrecursion
Allow specifying a cell range when reading spreadsheets (#1954)
5aa65fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeusgd radeusgd radeusgd approved these changes

@4e6 4e6 Awaiting requested review from 4e6

@iamrecursion iamrecursion Awaiting requested review from iamrecursion

Assignees

@kustosz kustosz

Labels
--breaking Important: a change that will break a public API or user-facing behaviour p-highest Should be completed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kustosz @radeusgd