Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
There was unnecessary data copying happening when reading a file. There isn't anymore.
From the numbers reported in #1724 it brings the times down to ~1s. This is exactly the same as reading a file in pure Java, with a
FileInputStream
, which is pretty much the best time we can get on the JVM.Fixes #1724
Important Notes
Checklist
Please include the following checklist in your PR: