Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write XLSX files #1906

Merged
merged 5 commits into from
Jul 28, 2021
Merged

Write XLSX files #1906

merged 5 commits into from
Jul 28, 2021

Conversation

kustosz
Copy link
Contributor

@kustosz kustosz commented Jul 28, 2021

Pull Request Description

on the tin

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@kustosz kustosz added Type: Enhancement p-highest Should be completed ASAP labels Jul 28, 2021
@kustosz kustosz self-assigned this Jul 28, 2021
iamrecursion
iamrecursion approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a couple of cosmetics.

distribution/lib/Standard/Table/0.1.0/src/Data/Table.enso Outdated Show resolved Hide resolved
distribution/lib/Standard/Table/0.1.0/src/Io/Spreadsheet_Write_Mode.enso Outdated Show resolved Hide resolved
@kustosz kustosz merged commit 9ce6eb0 into main Jul 28, 2021
@kustosz kustosz deleted the wip/mk/write_xlsx branch July 28, 2021 11:51
iamrecursion pushed a commit that referenced this pull request Aug 2, 2021
@kustosz @iamrecursion
Write XLSX files (#1906)
e03853b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamrecursion iamrecursion iamrecursion approved these changes

@4e6 4e6 Awaiting requested review from 4e6

@radeusgd radeusgd Awaiting requested review from radeusgd

Assignees

@kustosz kustosz

Labels
p-highest Should be completed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kustosz @iamrecursion