CSV Writing #1894
CSV Writing #1894
Conversation
| @@ -41,7 +41,7 @@ from Standard.Base.Data.Number.Extensions export all hiding Math, String, Double | |||
| from Standard.Base.Data.Noise export all hiding Noise | |||
| from Standard.Base.Data.Pair export Pair | |||
| from Standard.Base.Data.Range export Range | |||
| from Standard.Base.Data.Text.Extensions export Text, Split_Kind | |||
| from Standard.Base.Data.Text.Extensions export Text, Split_Kind, Line_Ending_Style | |||
There was a problem hiding this comment.
Do we really want this exported by default rather than accessible as Text.Line_Ending_Style?
There was a problem hiding this comment.
Line_Ending_Style seems rather clear to me on its own. And Text.Line_Ending_Style is a looot to type.
There was a problem hiding this comment.
Then I'd go with Text.Line_Ending. What if we ever introduce another kind of line ending style?
| example_to_csv = Examples.inventory_table.to_csv | ||
| to_csv : Boolean -> Boolean -> Text -> Line_Ending_Style.Line_Ending_Style -> Text |
There was a problem hiding this comment.
| example_to_csv = Examples.inventory_table.to_csv | |
| to_csv : Boolean -> Boolean -> Text -> Line_Ending_Style.Line_Ending_Style -> Text | |
| example_to_csv = Examples.inventory_table.to_csv | |
| to_csv : Boolean -> Boolean -> Text -> Line_Ending_Style.Line_Ending_Style -> Text |
There was a problem hiding this comment.
We don't do this, ever :)
| - file: the file to write the generated CSV contents to. Note that other | ||
| files may be created or written to if `max_rows_per_file` is used. |
There was a problem hiding this comment.
What happens if the file exists and has contents? You should probably have a should_overwrite parameter.
There was a problem hiding this comment.
We don't do it for any other file-writing method though? So this seems consistent and if we want to change it, we should probably change all places where this could happen. What do you think?
There was a problem hiding this comment.
Then we probably should have it elsewhere, but not worth it for now. File an issue.
| example_to_csv = Examples.inventory_table.write_csv (Enso_Project.data / example_csv_output.csv) | ||
| write_csv : File.File -> Boolean -> Boolean -> Text -> Line_Ending_Style.Line_Ending_Style -> Nothing | Integer -> Nothing |
There was a problem hiding this comment.
| example_to_csv = Examples.inventory_table.write_csv (Enso_Project.data / example_csv_output.csv) | |
| write_csv : File.File -> Boolean -> Boolean -> Text -> Line_Ending_Style.Line_Ending_Style -> Nothing | Integer -> Nothing | |
| example_to_csv = Examples.inventory_table.write_csv (Enso_Project.data / example_csv_output.csv) | |
| write_csv : File.File -> Boolean -> Boolean -> Text -> Line_Ending_Style.Line_Ending_Style -> Nothing | Integer -> Nothing |
Pull Request Description
Writes CSVs.
Important Notes
Checklist
Please include the following checklist in your PR: