Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Legal Notices Order Deterministic #1891

Merged
merged 3 commits into from
Jul 22, 2021
Merged

Make Legal Notices Order Deterministic #1891

merged 3 commits into from
Jul 22, 2021

Conversation

radeusgd
Copy link
Member

Pull Request Description

Closes #1833

Important Notes

  • It is currently based off the branch associated with Library Downloads MVP #1885 to avoid conflicts, it should be rebased to main once that is merged.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@radeusgd radeusgd self-assigned this Jul 21, 2021
@radeusgd radeusgd added Category: Build d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint labels Jul 21, 2021
4e6
4e6 approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@4e6 4e6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

kustosz
kustosz approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@kustosz kustosz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was not reviewed by me, misclick

@radeusgd radeusgd force-pushed the wip/rw/deterministic-legal-notices branch from e0018f6 to dc5a530 Compare July 21, 2021 13:03
@radeusgd radeusgd force-pushed the wip/rw/library-downloader branch from 0ba0336 to 2ce4326 Compare July 21, 2021 13:12
@radeusgd radeusgd force-pushed the wip/rw/deterministic-legal-notices branch 5 times, most recently from 5f70926 to 131d986 Compare July 21, 2021 18:51
Base automatically changed from wip/rw/library-downloader to main July 22, 2021 06:24
@radeusgd radeusgd force-pushed the wip/rw/deterministic-legal-notices branch from 131d986 to 30d8674 Compare July 22, 2021 07:35
@radeusgd radeusgd force-pushed the wip/rw/deterministic-legal-notices branch from 30d8674 to 116380b Compare July 22, 2021 09:19
@radeusgd radeusgd merged commit 5e86343 into main Jul 22, 2021
@radeusgd radeusgd deleted the wip/rw/deterministic-legal-notices branch July 22, 2021 11:00
iamrecursion pushed a commit that referenced this pull request Jul 23, 2021
@radeusgd @iamrecursion
Make Legal Notices Order Deterministic (#1891)
6e8d3c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kustosz kustosz kustosz approved these changes

@4e6 4e6 4e6 approved these changes

@iamrecursion iamrecursion Awaiting requested review from iamrecursion

Assignees

@radeusgd radeusgd

Labels
d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deterministic Order in Notices Generator
3 participants
@radeusgd @4e6 @kustosz