Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable interrupts to protect HostClassLoader #1867

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Disable interrupts to protect HostClassLoader #1867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50083e3
Disable interrupts to protect HostClassLoader
iamrecursion Jul 15, 2021
384b8b7
Changelog
iamrecursion Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions RELEASES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
- Ensure that the module used by a visualization is preloaded when the
visualization is being attached
([#1857](https://github.com/enso-org/enso/pull/1857)).
- Fix an issue with the `HostClassLoader` getting into a broken state
([#1867](https://github.com/enso-org/enso/pull/1867)).

## Tooling

Expand Down
4 changes: 2 additions & 2 deletions engine/runtime/src/main/scala/org/enso/interpreter/instrument/job/ExecuteJob.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ class ExecuteJob(
) extends Job[Unit](
List(contextId),
isCancellable = true,
// TODO[MK]: make this interruptible when https://github.com/oracle/graal/issues/3273
// TODO[MK]: make this interruptible when https://github.com/oracle/graal/issues/3590
// is resolved
mayInterruptIfRunning = true
mayInterruptIfRunning = false
) {

def this(exe: Executable) =
Expand Down