Support for Multiple Content Roots #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
force-pushed
the
wip/rw/extend-content-roots
branch
2 times, most recently
from
31afa9d to
befd664
Compare
4e6
requested changes
Jun 29, 2021
| @@ -2235,8 +2176,7 @@ addition of the root in order to inform them of the content root's ID. | |||
|
|
|||
| ```typescript | |||
| { | |||
| id: UUID; // The content root ID | |||
| absolutePath: [String]; | |||
| root: ContentRoot; | |||
There was a problem hiding this comment.
Just a reminder to make sure that the appropriate task is scheduled on the IDE side
There was a problem hiding this comment.
@farmaazon @MichaelMauderer I understand that this will likely need to be integrated for the https://github.com/enso-org/ide/issues/1634
Besides, I understand that before that the file/rootAdded notification was not being handled. Is it a breaking change for the IDE that we will start sending it? Will it cause errrors if you have no handler for it? If yes, I'd like to ask if you can add at least a dummy handler for compatibility which can later be extended to its full functionality.
.../language-server/src/main/scala/org/enso/languageserver/filemanager/ContentRootManager.scala
Show resolved
Hide resolved
...uage-server/src/main/scala/org/enso/languageserver/filemanager/ContentRootManagerActor.scala
Show resolved
Hide resolved
4e6
approved these changes
Jun 29, 2021
now it uses the Manager
from old Config static content roots
Had to change the initialization logic slightly to avoid duplicating the initial set of roots; the external behaviour should remain the same
which are published by the RuntimeConnector on the eventStream
radeusgd
force-pushed
the
wip/rw/extend-content-roots
branch
from
befd664 to
67826d2
Compare
4 tasks
iamrecursion
pushed a commit
that referenced
this pull request
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #1780
Important Notes
Checklist
Please include the following checklist in your PR: