Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Spec to Conform to the Implementation #1807

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Fix the Spec to Conform to the Implementation #1807

merged 1 commit into from
Jun 21, 2021

Conversation

iamrecursion
Copy link
Contributor

Pull Request Description

On the tin. Just something I missed in the original PR.

Important Notes

N/A

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@iamrecursion iamrecursion added Type: Enhancement p-highest Should be completed ASAP w-docs Website: Documentation labels Jun 21, 2021
@iamrecursion iamrecursion requested a review from 4e6 June 21, 2021 09:39
@iamrecursion iamrecursion self-assigned this Jun 21, 2021
@iamrecursion iamrecursion requested a review from kustosz as a code owner June 21, 2021 09:39
@iamrecursion iamrecursion merged commit 57f1913 into main Jun 21, 2021
@iamrecursion iamrecursion deleted the wip/ara/fix-spec branch June 21, 2021 09:46
iamrecursion added a commit that referenced this pull request Jun 24, 2021
@iamrecursion
Fix a missing change in the LS protocol spec (#1807)
ed7c45b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4e6 4e6 4e6 approved these changes

@kustosz kustosz Awaiting requested review from kustosz

Assignees

@iamrecursion iamrecursion

Labels
p-highest Should be completed ASAP w-docs Website: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamrecursion @4e6