Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP Library Updates #1722

Merged
merged 4 commits into from
May 4, 2021
Merged

HTTP Library Updates #1722

merged 4 commits into from
May 4, 2021

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented May 4, 2021

Pull Request Description

Misc fixes to HTTP library. I was playing with GitHub API this morning and found a couple of things that could be improved.

Changelog:

  • fix: Uri.to_json
  • feat: add error type to Request_Error. Sometimes Java does not provide an error message in exception. The error type gives some extra information about the error.
  • feat: support both Text and Json when sending JSON in the method body.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@4e6 4e6 added Type: Bug p-medium Should be completed in the next few sprints labels May 4, 2021
@4e6 4e6 self-assigned this May 4, 2021
iamrecursion
iamrecursion approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure you've re-checked the examples for the methods that you've touched.

@4e6 4e6 merged commit 24d299d into main May 4, 2021
@4e6 4e6 deleted the wip/db/http-fixes branch May 4, 2021 15:59
iamrecursion pushed a commit that referenced this pull request Jun 24, 2021
@4e6 @iamrecursion
HTTP Library Updates (#1722)
17dc29b 
Misc fixes to HTTP library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamrecursion iamrecursion iamrecursion approved these changes

@kustosz kustosz Awaiting requested review from kustosz

@radeusgd radeusgd Awaiting requested review from radeusgd

@wdanilo wdanilo Awaiting requested review from wdanilo

Assignees

@4e6 4e6

Labels
p-medium Should be completed in the next few sprints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4e6 @iamrecursion