Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Suggestions Database Schema Version #1703

Merged
merged 18 commits into from
Apr 28, 2021
Merged

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Apr 27, 2021

Pull Request Description

close #1590

Changelog:

  • feat: initialize suggestions database based on a schema version
  • update: set SQLite journaling mode to memory

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@4e6 4e6 added Type: Enhancement p-high Should be completed in the next sprint labels Apr 27, 2021
@4e6 4e6 self-assigned this Apr 27, 2021
Copy link
Contributor

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual fix looks good, but the log messages are lacking again.

val initAction =
for {
_ <- Future {
log.info("Initializing suggestions repo.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is it being initialized? You need to log actually useful information!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source class is included in the log entry.

[info] [2021-04-28T07:41:24.949Z] [org.enso.languageserver.boot.resource.RepoInitialization] Initializing suggestions repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Included the database file being initialized 👍

@iamrecursion iamrecursion merged commit ff54c07 into main Apr 28, 2021
@iamrecursion iamrecursion deleted the wip/db/suggestions-journal branch April 28, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-high Should be completed in the next sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using Enso through the IDE, the file system is accessed very frequently
2 participants