-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Suggestions Database Schema Version #1703
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actual fix looks good, but the log messages are lacking again.
val initAction = | ||
for { | ||
_ <- Future { | ||
log.info("Initializing suggestions repo.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is it being initialized? You need to log actually useful information!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source class is included in the log entry.
[info] [2021-04-28T07:41:24.949Z] [org.enso.languageserver.boot.resource.RepoInitialization] Initializing suggestions repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Included the database file being initialized 👍
Pull Request Description
close #1590
Changelog:
Important Notes
Checklist
Please include the following checklist in your PR: