Synchronize Runtime Updates Sending #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamrecursion
suggested changes
Apr 26, 2021
engine/runtime/src/main/java/org/enso/interpreter/instrument/UpdatesSynchronizationState.java
Show resolved
Hide resolved
iamrecursion
approved these changes
Apr 26, 2021
iamrecursion
pushed a commit
that referenced
this pull request
Apr 28, 2021
Add `UpdatesSynchronizationState` that manages the runtime update messages and tracks which updates are sent to the user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
close #1594
PR adds
UpdatesSynchronizationStatethat manages the runtime update messages and tracks which updates are sent to the user. The new logic covers situations when the runtime state has changed, but the program thread was interrupted before the runtime was able to prepare and send appropriate updates to the user.Changelog
UpdatesSynchronizationStatethat manages the state of runtime updatesRuntimeVisualisationsTestsuiteImportant Notes
Checklist
Please include the following checklist in your PR: