Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Table Visualization When No Index Is Present #1595

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Fix Table Visualization When No Index Is Present #1595

merged 1 commit into from
Mar 19, 2021

Conversation

radeusgd
Copy link
Member

Pull Request Description

Fixes an issue introduced in #1582

  • the code would fail for dataframes with no index set
  • dataframes without index would not get their default 0-N index displayed

With these changes these issues are resolved.

Important Notes

  • It would be very important to merge this before the upcoming release.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@radeusgd radeusgd self-assigned this Mar 18, 2021
@radeusgd radeusgd added Category: Libraries p-highest Should be completed ASAP labels Mar 18, 2021
@radeusgd radeusgd mentioned this pull request Mar 18, 2021
Merged
9 tasks
@iamrecursion iamrecursion merged commit 8c9c293 into main Mar 19, 2021
@iamrecursion iamrecursion deleted the wip/rw/fix-table-vis branch March 19, 2021 08:19
iamrecursion pushed a commit that referenced this pull request Mar 19, 2021
@radeusgd @iamrecursion
Fix table visualization when no index is present (#1595)
db57549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamrecursion iamrecursion iamrecursion approved these changes

@kustosz kustosz Awaiting requested review from kustosz

@wdanilo wdanilo Awaiting requested review from wdanilo

Assignees

@radeusgd radeusgd

Labels
p-highest Should be completed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@radeusgd @iamrecursion