Add Locations Filter for Instrumented Locations #1564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kustosz
approved these changes
Mar 12, 2021
There was a problem hiding this comment.
- The code looks good.
- Tested this build in the IDE – my original "lambda slow" case is now indeed fixed. Using the
_sugar instead of a lambda in the same spot is also fixed. - Before merging, please clarify for me the status of the block tests – why are they pending and why do they assert thunks in places that should be forces.
| context.receive(4) should contain allOf ( | ||
| Api.Response(requestId, Api.PushContextResponse(contextId)), | ||
| TestMessages.update(contextId, xExpr, Constants.THUNK), | ||
| TestMessages.update(contextId, mainRes, Constants.THUNK), |
There was a problem hiding this comment.
this should be an integer, not a thunk
There was a problem hiding this comment.
It's pending because of #1567
| context.receive(5) should contain allOf ( | ||
| Api.Response(requestId, Api.PushContextResponse(contextId)), | ||
| TestMessages.update(contextId, xExpr, Constants.THUNK), | ||
| TestMessages.update(contextId, mainRes, Constants.THUNK), |
There was a problem hiding this comment.
this should be an integer, not a thunk
There was a problem hiding this comment.
It's pending because of #1567
| } | ||
|
|
||
| it should "not instrument sugared lambdas in block expressions" in { | ||
| pending |
There was a problem hiding this comment.
It's pending because of #1566
iamrecursion
pushed a commit
that referenced
this pull request
Mar 16, 2021
PR adds the location filter that excludes lambdas and local functions from the instrumentation.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
close #1529
PR adds the location filter that excludes lambdas and local functions from the instrumentation.
Changelog:
feat: implement locations filter that extracts a comprehensive list of locations that should be instrumented
feat: instantiate the runtime instrument using the new location filter
test: add test suite that checks instrumented locations
Important Notes
Checklist
Please include the following checklist in your PR: