-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python interop #1541
Merged
Merged
Python interop #1541
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9baa5f6
do python
kustosz 496d732
fixes
kustosz eadcce7
run tests conditionally
kustosz 54c2591
final_1
kustosz dca6a80
CR feedback
kustosz b604572
fix javadoc
kustosz bac2dc3
Merge branch 'main' into wip/mk/python
kustosz 7b17831
foo
kustosz 8cc31a4
Revert "foo"
kustosz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
engine/runtime/src/main/java/org/enso/interpreter/epb/node/PyForeignNode.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
package org.enso.interpreter.epb.node; | ||
|
||
import com.oracle.truffle.api.dsl.NodeField; | ||
import com.oracle.truffle.api.dsl.Specialization; | ||
import com.oracle.truffle.api.interop.ArityException; | ||
import com.oracle.truffle.api.interop.InteropLibrary; | ||
import com.oracle.truffle.api.interop.UnsupportedMessageException; | ||
import com.oracle.truffle.api.interop.UnsupportedTypeException; | ||
import com.oracle.truffle.api.library.CachedLibrary; | ||
|
||
@NodeField(name = "foreignFunction", type = Object.class) | ||
public abstract class PyForeignNode extends ForeignFunctionCallNode { | ||
|
||
abstract Object getForeignFunction(); | ||
|
||
@Specialization | ||
public Object doExecute( | ||
Object[] arguments, @CachedLibrary("foreignFunction") InteropLibrary interopLibrary) { | ||
try { | ||
return interopLibrary.execute(getForeignFunction(), arguments); | ||
} catch (UnsupportedMessageException | UnsupportedTypeException | ArityException e) { | ||
throw new IllegalStateException("Python parser returned a malformed object", e); | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you implement the
JsForeignNode
using@NodeField
? Consistency matters for this, otherwise it might be seen as intentional or important.