Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dependency Analysis #1495

Merged
merged 3 commits into from
Feb 19, 2021
Merged

Fix Dependency Analysis #1495

merged 3 commits into from
Feb 19, 2021

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Feb 19, 2021

Pull Request Description

close #1483

PR fixes dependency analysis on IR.Error nodes.

Changelog:

  • fix: dataflow analysis takes into account external node ids when building dynamic references.
  • fix: ChangesetBuilder queries dependencies of dynamic symbols (in addition to stable identifiers)

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@4e6 4e6 added Type: Bug p-highest Should be completed ASAP labels Feb 19, 2021
@4e6 4e6 self-assigned this Feb 19, 2021
@4e6 4e6 merged commit dced7b9 into main Feb 19, 2021
@4e6 4e6 deleted the wip/db/execute-after-error branch February 19, 2021 16:38
iamrecursion pushed a commit that referenced this pull request Feb 23, 2021
@4e6 @iamrecursion
Fix Dependency Analysis (#1495)
f147ed0 
PR fixes dependency analysis on IR.Error nodes.
@4e6 4e6 mentioned this pull request Mar 1, 2021
Merged
4 tasks
4e6 added a commit that referenced this pull request Mar 1, 2021
@4e6
Fix Invalidation of Dynamic Dependencies (#1532)
2bba2cc 
Revert change from #1495, where dynamic 
dependencies come with external ids.
iamrecursion pushed a commit that referenced this pull request Mar 2, 2021
@4e6 @iamrecursion
Fix Invalidation of Dynamic Dependencies (#1532)
39728bf 
Revert change from #1495, where dynamic 
dependencies come with external ids.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamrecursion iamrecursion iamrecursion approved these changes

@kustosz kustosz Awaiting requested review from kustosz

@radeusgd radeusgd Awaiting requested review from radeusgd

Assignees

@4e6 4e6

Labels
p-highest Should be completed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Language Server does not send expressionUpdate removing error.
2 participants
@4e6 @iamrecursion