Upgrade Graal to 21.0 #1487
Merged
Upgrade Graal to 21.0 #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kustosz
suggested changes
Feb 17, 2021
engine/runtime/src/main/java/org/enso/interpreter/epb/runtime/GuardedTruffleContext.java
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/epb/runtime/GuardedTruffleContext.java
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/epb/runtime/PolyglotExceptionProxy.java
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/epb/runtime/PolyglotProxy.java
Outdated
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/epb/runtime/PolyglotProxy.java
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/runtime/builtin/Builtins.java
Outdated
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/runtime/builtin/Builtins.java
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/runtime/builtin/Builtins.java
Outdated
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/runtime/error/PanicSentinel.java
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/runtime/scope/TopLevelScope.java
Outdated
Show resolved
Hide resolved
kustosz
approved these changes
Feb 17, 2021
iamrecursion
force-pushed
the
wip/ara/graal-21.0
branch
4 times, most recently
from
e54a450
to
a61eb6f
Compare
iamrecursion
force-pushed
the
wip/ara/graal-21.0
branch
from
2e1c6dc
to
b9859bf
Compare
iamrecursion
force-pushed
the
wip/ara/graal-21.0
branch
from
b9859bf
to
a8b0a9f
Compare
to avoid a Windows path length issue
radeusgd
approved these changes
Feb 22, 2021
There was a problem hiding this comment.
Looks good to me, I just have two minor questions.
Accepting conditionally on the release workflow succeeding on staging.
Also I think we need to remember to create an issue to improve the CI timing in the future, as there are places in the current workarounds that may be improved (only cleaning the instruments, avoiding additional rebuilds by only using the build*Distribution commands instead of assembly etc.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
We use the hotfix version
21.0.0.2.Closes #1481.
Closes #1296.
Important Notes
add-exportsstuff.Checklist
Please include the following checklist in your PR: