Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Correct Payload for Dataflow Errors #1484

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Set Correct Payload for Dataflow Errors #1484

merged 2 commits into from
Feb 18, 2021

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Feb 17, 2021

Pull Request Description

close #1480

Set DataflowError payload for dataflow error updates.

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@4e6 4e6 added Type: Bug p-highest Should be completed ASAP labels Feb 17, 2021
@4e6 4e6 requested a review from iamrecursion as a code owner February 17, 2021 07:59
@4e6 4e6 self-assigned this Feb 17, 2021
@4e6 4e6 requested review from kustosz and radeusgd as code owners February 17, 2021 07:59
@4e6 4e6 merged commit ad4d628 into main Feb 18, 2021
@4e6 4e6 deleted the wip/db/dataflow-error-payload branch February 18, 2021 12:05
iamrecursion pushed a commit that referenced this pull request Feb 23, 2021
@4e6 @iamrecursion
Set Correct Payload for Dataflow Errors (#1484)
e1fcd47 
Set DataflowError payload for dataflow error updates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamrecursion iamrecursion iamrecursion approved these changes

@kustosz kustosz Awaiting requested review from kustosz

@radeusgd radeusgd Awaiting requested review from radeusgd

Assignees

@4e6 4e6

Labels
p-highest Should be completed ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Language Server is not always reporting errors correctly.
2 participants
@4e6 @iamrecursion