Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image Processing Library Prototype #1450

Merged
merged 41 commits into from
Mar 23, 2021
Merged

Image Processing Library Prototype #1450

merged 41 commits into from
Mar 23, 2021

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Feb 4, 2021 •
edited
Loading

Pull Request Description

close #1350

Add the Standard.Image library. The library allows:

  • read and write images from files
  • apply arithmetic operations to image pixels
  • create histograms for each channel
  • visualize image and histogram data in IDE

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@4e6 4e6 self-assigned this Feb 4, 2021
@iamrecursion iamrecursion changed the title Image Processing Library Image Processing Library Prototype Feb 5, 2021
@4e6 4e6 force-pushed the wip/db/image-lib branch from db3e25f to 1c14360 Compare March 17, 2021 15:52
@4e6 4e6 force-pushed the wip/db/image-lib branch from 532b2c9 to 532fd52 Compare March 18, 2021 08:33
@4e6 4e6 marked this pull request as ready for review March 18, 2021 08:34
@4e6 4e6 requested a review from iamrecursion as a code owner March 18, 2021 08:34
iamrecursion
iamrecursion approved these changes Mar 18, 2021
View reviewed changes
distribution/std-lib/Standard/src/Base/Data/Vector.enso Outdated Show resolved Hide resolved
distribution/std-lib/Standard/src/Base/Data/Vector.enso Outdated Show resolved Hide resolved
distribution/std-lib/Standard/src/Image/Codecs.enso Outdated Show resolved Hide resolved
distribution/std-lib/Standard/src/Image/Codecs.enso Outdated Show resolved Hide resolved
distribution/std-lib/Standard/src/Image/Codecs.enso Outdated Show resolved Hide resolved
test/Image_Tests/src/Data/Image_Spec.enso Outdated Show resolved Hide resolved
test/Image_Tests/src/Data/Matrix_Spec.enso Outdated Show resolved Hide resolved
test/Image_Tests/src/Data/Matrix_Spec.enso Show resolved Hide resolved
test/Image_Tests/src/Data/Image_Spec.enso Outdated Show resolved Hide resolved
test/Image_Tests/src/Data/Image_Spec.enso Show resolved Hide resolved
iamrecursion
iamrecursion suggested changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait oops I meant to ask for changes.

@4e6 4e6 requested a review from iamrecursion March 22, 2021 07:24
iamrecursion
iamrecursion suggested changes Mar 23, 2021
View reviewed changes
distribution/std-lib/Standard/src/Image/Codecs.enso Outdated
Write the image with applying several flags.
Codecs.write path image [Codecs.Write_Jpeg_Quality 40, Codecs.Write_Jpeg_Progressive]
write : (Text | File) -> Image -> (Write_Flag | Vector) -> Nothing ! File.Io_Error
write location image flags=[] =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What we talked about for this function.

iamrecursion
iamrecursion approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

@4e6 4e6 merged commit 534ed30 into main Mar 23, 2021
@4e6 4e6 deleted the wip/db/image-lib branch March 23, 2021 10:16
@4e6 4e6 mentioned this pull request Mar 24, 2021
Merged
9 tasks
iamrecursion pushed a commit that referenced this pull request Mar 26, 2021
@4e6 @iamrecursion
Image Processing Library Prototype (#1450)
6c4dcf6 
Add the Standard.Image library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamrecursion iamrecursion iamrecursion approved these changes

@kustosz kustosz Awaiting requested review from kustosz

@radeusgd radeusgd Awaiting requested review from radeusgd

@wdanilo wdanilo Awaiting requested review from wdanilo

Assignees

@4e6 4e6

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image Processing Library
2 participants
@4e6 @iamrecursion