Fluent Java Interop & Method Dispatch Refactor #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kustosz
added
Type: Enhancement
--breaking
iamrecursion
approved these changes
Feb 1, 2021
| fst = iterator.first [] | ||
| nxt = iterator.next [] | ||
| fst = iterator.first | ||
| nxt = iterator.next |
There was a problem hiding this comment.
Surely we can use next here now, given that we no longer have UFCS! Other locations too.
There was a problem hiding this comment.
We sure can. But this PR had too much boy-scouting in other places already, it's just too much for one person :P
| @@ -4,5 +4,5 @@ import Builtins | |||
| ## Checks whether an object is an instance of a given class. | |||
| Builtins.Java.is_instance : Any -> Any -> Boolean | |||
| Builtins.Java.is_instance object class = | |||
| class_object = Polyglot.get_member class "class" | |||
| class_object.isInstance [object] | |||
| class_object = class.class | |||
| argumentsExecutionMode, | ||
| isTail); | ||
| } catch (MethodDispatchLibrary.NoSuchMethodException e) { | ||
| CompilerDirectives.transferToInterpreter(); |
There was a problem hiding this comment.
We really need a consistent rule for whether we use this or not when throwing.
There was a problem hiding this comment.
Fair. Let's stick with don't use for new code.
Comment on lines
21
to
+23
| build_map size = | ||
| rand = Random.new [].to_array | ||
| 0.up_to size . fold Map.empty (m -> i -> m.insert (rand.nextInt [10000]) i) | ||
| rand = Random.new | ||
| 0.up_to size . fold Map.empty (m -> i -> m.insert (rand.nextInt 10000) i) |
There was a problem hiding this comment.
Did you fix the other benchmarks? They use polyglot a lot.
iamrecursion
pushed a commit
that referenced
this pull request
Feb 10, 2021
iamrecursion
pushed a commit
that referenced
this pull request
Feb 11, 2021
iamrecursion
pushed a commit
that referenced
this pull request
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Removes currying for polyglot calls while also removing the need for vectored arguments and unifying field/method access patterns. Also pushes the method dispatch logic to a truffle library, so that our resolution logic can be more object-oriented and less "let me try to handle every single type of value in one node".
Important Notes
Checklist
Please include the following checklist in your PR: