Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Null Check when Executing Host Values #1413

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Jan 19, 2021

Pull Request Description

close #1401

Fix the execution of default arguments (represented with null values) by adding an extra null check.

Changelog:

  • add: extra null check, because isNull doesn't allow null arguments

Important Notes

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All documentation and configuration conforms to the markdown and YAML style guides.
  • All code has been tested where possible.

@4e6 4e6 added Type: Bug p-high Should be completed in the next sprint labels Jan 19, 2021
@4e6 4e6 self-assigned this Jan 19, 2021
@4e6 4e6 merged commit 3648011 into main Jan 19, 2021
@4e6 4e6 deleted the wip/db/execute-default-args branch January 19, 2021 19:04
iamrecursion pushed a commit that referenced this pull request Feb 10, 2021
add: extra null check, because isNull doesn't allow
null arguments
iamrecursion pushed a commit that referenced this pull request Feb 11, 2021
add: extra null check, because isNull doesn't allow
null arguments
iamrecursion pushed a commit that referenced this pull request Feb 11, 2021
add: extra null check, because isNull doesn't allow
null arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-high Should be completed in the next sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in function main when entering function with default argument.
2 participants