Report duplicates in the IR after each pass #11873
Conversation
JaroslavTulach
added
CI: No changelog needed
JaroslavTulach
requested review from
4e6,
hubertp and
Akirathan
as code owners
…CPU to finish the tests.
| if (reported.containsKey(System.identityHashCode(e))) { | ||
| false | ||
| } else { | ||
| if (idMap.containsKey(e)) { |
There was a problem hiding this comment.
Scans for current ir in preorder and finds first == IR element that appears twice and hasn't yet been reported.
If such a duplFound, then it scans the IR again to find all elements that have the duplFound.orNull among their children() and prints that up.
The results of such a scan are visible in the log for example like:
Duplicate found after org.enso.compiler.pass.desugar.FunctionBinding$: org.enso.compiler.core.ir.Name$Literal@6edf29c1:Named_Pattern
referenced by org.enso.compiler.core.ir.module.scope.definition.Method$Conversion@3791f50e:Regex.from = (that : Named_Pattern) -> ((compile) Regex ((regex_pattern) that))
referenced by org.enso.compiler.core.ir.DefinitionArgument$Specified@7c8c70d6:(that : Named_Pattern)
In some cases such a sharing seems innocent, but in others it may be dangerous. Such a dangerous sharing was probably triggered by #11365 - investigation pending.
JaroslavTulach
added
the
CI: Clean build required
| @@ -50,7 +50,8 @@ case object Imports extends IRPass { | |||
| val parts = newName.parts | |||
| if (parts.length == 2) { | |||
| i.copy( | |||
| name = newName.copy(parts = parts :+ mainModuleName), | |||
| name = | |||
| newName.copy(parts = parts :+ mainModuleName.duplicate()), | |||
There was a problem hiding this comment.
There was a report:
Duplicate found after org.enso.compiler.pass.desugar.Imports$: org.enso.compiler.core.ir.Name$Literal@56476c16:Main
referenced by org.enso.compiler.core.ir.Name$Qualified@76e9f00b:Standard.Base.Main
referenced by org.enso.compiler.core.ir.Name$Qualified@314b9e4b:Standard.Test.Main
and with bb4aff2 it is gone.
| underlying.isLoggable(level) | ||
| } catch { |
There was a problem hiding this comment.
There is a runtime-instrument-common/testOnly *ChangesetBuilderTest failure which gets fixed by b4f3973
Pull Request Description
As part of work on #9165 a #11365 PR was created. However it seems that some
IRelements are being referenced by multiple parentIRelements and that is causing issues with their metadata being updated multiple times and with different values. This PR is an investigation of what happens, why and by whom?Your ideas are welcomed although I am going to change the PR state to draft. It is unlikely to get merged in this state anyway.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,