Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow a confusing constructor syntax #11856

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented Dec 12, 2024

Pull Request Description

Previously, a constructor or type definition with a single argument defined inline could use spaces within the argument's definition without parentheses, as in the draft spec. This syntax was found confusing and is no longer allowed. No usages occurred in our .enso files. Fixes #10812.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@kazcw kazcw self-assigned this Dec 12, 2024
@kazcw kazcw marked this pull request as ready for review December 12, 2024 21:01
@kazcw kazcw added the CI: Ready to merge This PR is eligible for automatic merge label Dec 16, 2024
@mergify mergify bot merged commit d2ae17f into develop Dec 16, 2024
42 of 43 checks passed
@mergify mergify bot deleted the wip/kw/stricter-ctor-syntax branch December 16, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seemingly invalid syntax accepted without errors?
3 participants