Autolinks in documentation editor #11597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Separate parser for our flavor of Markdown from the CodeMirror integration; move the parser into ydoc-shared and use for Markdown line-wrapping. - Introduce our own version of yCollab extension; initially just the upstream version translated to Typescript and our code style. - Refactor CodeEditor.
Also a little refactoring in preparation for new implementation.
Eliminates Lexical dependency. Stacked on #11575 and #31607.
This reverts commit 7431384.
This reverts commit 7431384.
…wip/kw/doc-tables
- Markdown editor renders autolinks (`<https://example.com>`). - Markdown editor converts URLs in pasted text to autolink syntax. - Markdown editor supports raw paste (Shift+Ctrl+V), which doesn't autolink. - Markdown parser no longer supports GitHub-style unmarked autolinks.
kazcw
requested review from
GregoryTravis,
marthasharkey,
4e6,
JaroslavTulach,
hubertp and
Akirathan
as code owners
farmaazon
removed request for
PabloBuchu,
indiv0,
somebody1234,
MrFlashAccount,
jdunkerley,
radeusgd,
GregoryTravis,
marthasharkey,
4e6,
JaroslavTulach,
hubertp and
Akirathan
farmaazon
approved these changes
Nov 21, 2024
| 'image/png': { extension: 'png' }, | ||
| 'image/svg+xml': { extension: 'svg' }, | ||
| 'image/webp': { extension: 'webp' }, | ||
| // Question: do we want to have BMP and ICO here? |
There was a problem hiding this comment.
Talking with @Frizi we decided that we do not, but I forgot to remove this comment.
🧪 Storybook is successfully deployed!📊 Dashboard:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Autolinks in documentation
<https://example.com>).Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.