Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add undo/redo buttons to the top bar #11433

Merged
merged 6 commits into from
Oct 30, 2024
Merged

Conversation

vitvakatu
Copy link
Contributor

Pull Request Description

Closes #11222

undo-redo-buttons.mp4

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@vitvakatu vitvakatu added x-new-feature Type: new feature request -gui labels Oct 29, 2024
@vitvakatu vitvakatu self-assigned this Oct 29, 2024
@vitvakatu vitvakatu requested a review from farmaazon October 29, 2024 12:58
type UnionToIntersection<U> =
(U extends any ? (k: U) => void : never) extends (k: infer I) => void ? I : never
type LastOf<T> =
UnionToIntersection<T extends any ? (x: T) => void : never> extends (x: infer L) => void ? L
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admit I don't understand this. Why this UnionToIntersection takes a function type, not a union? Any chance of explanation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, not a chance.

After researching it a bit, I think the current implementation is too fragile to use, I will come up with something else.

@vitvakatu vitvakatu added the CI: Ready to merge This PR is eligible for automatic merge label Oct 30, 2024
@mergify mergify bot merged commit 0d731ad into develop Oct 30, 2024
34 of 37 checks passed
@mergify mergify bot deleted the wip/vitvakatu/undo-redo-buttons branch October 30, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: Ready to merge This PR is eligible for automatic merge x-new-feature Type: new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Undo/Redo buttons
2 participants