-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add undo/redo buttons to the top bar #11433
Conversation
type UnionToIntersection<U> = | ||
(U extends any ? (k: U) => void : never) extends (k: infer I) => void ? I : never | ||
type LastOf<T> = | ||
UnionToIntersection<T extends any ? (x: T) => void : never> extends (x: infer L) => void ? L |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I admit I don't understand this. Why this UnionToIntersection
takes a function type, not a union? Any chance of explanation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, not a chance.
After researching it a bit, I think the current implementation is too fragile to use, I will come up with something else.
Pull Request Description
Closes #11222
undo-redo-buttons.mp4
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.