Fix Meta.get_qualified_type_name when run as single file #11401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If pkg is not null, qualified name must be provided.
Akirathan
added
the
CI: No changelog needed
Akirathan
requested review from
4e6,
JaroslavTulach and
hubertp
as code owners
Akirathan
changed the title
JaroslavTulach
approved these changes
Oct 25, 2024
...untime-integration-tests/src/test/java/org/enso/interpreter/test/meta/QualifiedNameTest.java
Show resolved
Hide resolved
Akirathan
commented
Oct 30, 2024
Comment on lines
+166
to
+186
| private void ensureConsistentName(QualifiedName name, Package<TruffleFile> pkg) { | ||
| if (name.toString().equals(Builtins.MODULE_NAME)) { | ||
| return; | ||
| } | ||
| if (pkg != null && name.isSimple()) { | ||
| throw new IllegalArgumentException( | ||
| "Simple module name must not be in a package, i.e., trying to initialize a module in a" | ||
| + " package '" | ||
| + pkg.libraryName().toString() | ||
| + "' with a simple name '" | ||
| + name | ||
| + "'"); | ||
| } else if (pkg == null && !name.isSimple()) { | ||
| throw new IllegalArgumentException( | ||
| "Qualified module name must be in a package, i.e., trying to initialize " | ||
| + "a module with a qualified name '" | ||
| + name | ||
| + "' without a package"); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This sanity check is the gist of this PR
Akirathan
requested review from
jdunkerley,
radeusgd,
GregoryTravis,
AdRiley and
marthasharkey
as code owners
GregoryTravis
approved these changes
Oct 31, 2024
radeusgd
reviewed
Oct 31, 2024
...me-integration-tests/src/test/scala/org/enso/compiler/test/semantic/TypeSignaturesTest.scala
Show resolved
Hide resolved
MrFlashAccount
pushed a commit
that referenced
this pull request
Nov 1, 2024
`Meta.get_qualified_type_name` correctly returns fully qualified type name when running a single file from a project with `enso --run Proj/src/Main.enso`.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10228
Pull Request Description
Meta.get_qualified_type_namecorrectly returns fully qualified type name when running a single file from a project withenso --run Proj/src/Main.enso.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.