Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SQLServer Sort Feature and associated tests #11379

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from

Conversation

AdRiley
Copy link
Member

@AdRiley AdRiley commented Oct 22, 2024

Pull Request Description

Enables Sort Feature Flag and the corresponding tests.

Takes SQLServer test suite from 92 to 265 passing tests

Important Notes

The boolean and null handling for SQLServer is very different to different database which has introduced more duplication than I would have liked. But I am hesitant to exposed the other dialects to the additional complication required by SQLServer.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@AdRiley AdRiley added the CI: No changelog needed Do not require a changelog entry for this PR. label Oct 22, 2024
@AdRiley AdRiley marked this pull request as ready for review October 22, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant