Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AssetSearchBar E2E tests #11377

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

somebody1234
Copy link
Contributor

@somebody1234 somebody1234 commented Oct 22, 2024

Pull Request Description

Important Notes

None

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • ~~If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.~~

@somebody1234 somebody1234 added CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard labels Oct 22, 2024
@@ -10,7 +10,7 @@ import { defineConfig } from '@playwright/test'
import net from 'net'

const DEBUG = process.env.DEBUG_E2E === 'true'
const TIMEOUT_MS = DEBUG ? 100_000_000 : 30_000
const TIMEOUT_MS = DEBUG ? 100_000_000 : 60_000
Copy link
Contributor

@MrFlashAccount MrFlashAccount Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increasing the timeout significantly affects the test pass time (if we have a failing test, we'll have to wait for 60_000 * 5 retries instead of 30_000 * 5 retries before test fail (2.5 minutes longer for each fail!). This will also affect the DX because if the test fails, we have to wait longer to see the result (each iteration becomes much slower). Do we really need that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i think it does, i'm not a fan of it either but it's certainly causing some flakiness... perhaps we should only raise the timeout on CI? because i magine CI has slower machines - personally i've never (or rarely) experienced timeouts on my local machine - and CI machines shouldn't have timeouts because (ideally) you're supposed to run the E2E tests locally before push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assetSearchBar GUI test failure
2 participants