Limit light selection to "widget-colored" widgets only #11358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
requested review from
Frizi,
vitvakatu,
kazcw and
AdRiley
as code owners
Frizi
approved these changes
Oct 18, 2024
kazcw
approved these changes
Oct 18, 2024
| @@ -132,5 +132,9 @@ export const widgetDefinition = defineWidget( | |||
| outline: none; | |||
| background: var(--color-widget-focus); | |||
| } | |||
|
|
|||
| &:deep(::selection) { | |||
There was a problem hiding this comment.
:deep is not needed; Vue doesn't scope pseudo-element selectors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #10862
Before, we set selection to whit on entire node, but this looked bad in Table Widget.
Screencast.From.2024-10-18.15-23-40.webm
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
[ ] The documentation has been updated, if necessary.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
[ ] Unit tests have been written where possible.[ ] If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,or the Snowflake database integration, a run of the Extra Tests has been scheduled.