Inline doc comment is a compiler error #11333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akirathan
added
the
CI: No changelog needed
Akirathan
requested review from
4e6,
JaroslavTulach and
hubertp
as code owners
kazcw
requested review from
farmaazon,
kazcw,
vitvakatu,
Frizi and
AdRiley
as code owners
|
This should be a syntax error, so I added some parser changes. |
Frizi
approved these changes
Oct 15, 2024
hubertp
approved these changes
Oct 16, 2024
farmaazon
approved these changes
Oct 16, 2024
| @@ -89,6 +92,7 @@ impl<'s, Inner: TreeConsumer<'s>> CompoundTokens<'s, Inner> { | |||
| if let Some(tree) = self.compounding.take().and_then(|builder| builder.flush()) { | |||
| self.inner.push_tree(tree); | |||
| } | |||
| self.has_preceding_item = default(); | |||
There was a problem hiding this comment.
Personally, I'd prefer false, as more "readable"
There was a problem hiding this comment.
false would be simpler, but IMO it's more important here to express that the field is reset to its initial state than to emphasize the value of that state. I'd reinitialize the whole struct here, if it weren't for performance.
| @@ -260,18 +277,21 @@ impl<'s> CompoundTokenBuilder<'s> for TextLiteralBuilder<'s> { | |||
| } | |||
|
|
|||
| fn flush(self) -> Option<Tree<'s>> { | |||
| let Self { open, newline, elements } = self; | |||
| let Self { open, newline, elements, has_preceding_item: _ } = self; | |||
There was a problem hiding this comment.
A shorter form would be
Suggested change
| let Self { open, newline, elements, has_preceding_item: _ } = self; | |
| let Self { open, newline, elements, .. } = self; |
Unless you really want to have an error here when another field will be added.
There was a problem hiding this comment.
Fields that can correctly be ignored here are the exception.
JaroslavTulach
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fix NPE thrown when compiling source with inline documentation comments, like
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.