When connecting to a Postgres database through a datalink stored on Enso Cloud, its asset ID is included in the audit logs #11291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
added
the
CI: No changelog needed
radeusgd
requested review from
jdunkerley,
GregoryTravis,
AdRiley and
marthasharkey
as code owners
jdunkerley
approved these changes
Oct 10, 2024
| @@ -19,7 +19,7 @@ type S3_Data_Link | |||
| Value (uri : Text) format_json (credentials : AWS_Credential) | |||
|
|
|||
| ## PRIVATE | |||
| parse json -> S3_Data_Link = | |||
| parse json _ -> S3_Data_Link = | |||
There was a problem hiding this comment.
I know we are discarding this but can we do:
Suggested change
| parse json _ -> S3_Data_Link = | |
| parse json source -> S3_Data_Link = | |
| _ = source |
as clearer to read.
There was a problem hiding this comment.
Ok sure, I was also not sure if _ is right here, I think that named argument is indeed better - will amend all of them
distribution/lib/Standard/Base/0.0.0-dev/src/Enso_Cloud/Internal/Enso_File_Data_Link.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Base/0.0.0-dev/src/Network/HTTP/Internal/HTTP_Fetch_Data_Link.enso
Outdated
Show resolved
Hide resolved
distribution/lib/Standard/Snowflake/0.0.0-dev/src/Snowflake_Data_Link.enso
Outdated
Show resolved
Hide resolved
3 tasks
Base automatically changed from
wip/radeusgd/11227-cloud-asset-metadata
to
develop
October 10, 2024 12:11
This reverts commit dbf6a5e.
radeusgd
force-pushed
the
wip/radeusgd/9869-datalink-id-in-auditlog
branch
from
50a0921
to
dc9cb0d
Compare
AdRiley
approved these changes
Oct 10, 2024
GregoryTravis
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.