Don't send expression updates about interrupts #11218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no value in sending expression updates involving interrupts to the user. Adding more logging information to see how aborts affect execution.
hubertp
added
the
CI: No changelog needed
hubertp
requested review from
4e6,
JaroslavTulach and
Akirathan
as code owners
...instrument-common/src/main/java/org/enso/interpreter/instrument/job/VisualizationResult.java
Outdated
Show resolved
Hide resolved
Ensures that no sleep interrupt panics are being sent as expression updates.
hubertp
changed the title
4e6
approved these changes
Oct 1, 2024
| @@ -7,15 +7,15 @@ | |||
| public interface JobControlPlane { | |||
|
|
|||
| /** Aborts all interruptible jobs. */ | |||
| void abortAllJobs(); | |||
| void abortAllJobs(String reason); | |||
...ion-tests/src/test/scala/org/enso/interpreter/test/instrument/RuntimeAsyncCommandsTest.scala
Outdated
Show resolved
Hide resolved
...ion-tests/src/test/scala/org/enso/interpreter/test/instrument/RuntimeAsyncCommandsTest.scala
Outdated
Show resolved
Hide resolved
jdunkerley
pushed a commit
that referenced
this pull request
Oct 7, 2024
There is no value in sending expression updates involving interrupts to the user:  Adding more logging information to see how aborts affect execution. Related to #11084. (cherry picked from commit ad53c82)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
There is no value in sending expression updates involving interrupts to the user:
Adding more logging information to see how aborts affect execution.
Related to #11084.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.