Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wip/kw/detect parser misuse #11137

Closed
wants to merge 4 commits into from
Closed

Wip/kw/detect parser misuse #11137

wants to merge 4 commits into from

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented Sep 20, 2024 •
edited
Loading

Pull Request Description

Not intended to be merged. Demonstrates cause of #11121.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@kazcw
Improve backend error handling
4951a6f 
- Fix debug logging for #11088--attempt to create an exception that is its own
  cause fails.
- In case the parser is used after closing, throw an `IllegalStateException`
  instead of UB.
@kazcw
Detect race conditions in parser usage
c912a55
@kazcw
Revert "Detect race conditions in parser usage"
fb9eb1d 
This reverts commit c912a55.
@kazcw
Report race conditions
f331662
@JaroslavTulach
Copy link
Member

No longer needed now when #11147 has been merged.

@kazcw kazcw deleted the wip/kw/detect-parser-misuse branch October 4, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley Awaiting requested review from jdunkerley jdunkerley will be requested when the pull request is marked ready for review jdunkerley is a code owner

@radeusgd radeusgd Awaiting requested review from radeusgd radeusgd will be requested when the pull request is marked ready for review radeusgd is a code owner

@GregoryTravis GregoryTravis Awaiting requested review from GregoryTravis GregoryTravis will be requested when the pull request is marked ready for review GregoryTravis is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley will be requested when the pull request is marked ready for review AdRiley is a code owner

@marthasharkey marthasharkey Awaiting requested review from marthasharkey marthasharkey will be requested when the pull request is marked ready for review marthasharkey is a code owner

@farmaazon farmaazon Awaiting requested review from farmaazon farmaazon will be requested when the pull request is marked ready for review farmaazon is a code owner

@vitvakatu vitvakatu Awaiting requested review from vitvakatu vitvakatu will be requested when the pull request is marked ready for review vitvakatu is a code owner

@Frizi Frizi Awaiting requested review from Frizi Frizi will be requested when the pull request is marked ready for review Frizi is a code owner

@JaroslavTulach JaroslavTulach Awaiting requested review from JaroslavTulach JaroslavTulach will be requested when the pull request is marked ready for review JaroslavTulach is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazcw @JaroslavTulach