Improve backend error handling #11136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix debug logging for #11088--attempt to create an exception that is its own cause fails. - In case the parser is used after closing, throw an `IllegalStateException` instead of UB.
kazcw
requested review from
jdunkerley,
radeusgd,
GregoryTravis,
AdRiley,
marthasharkey,
farmaazon,
vitvakatu,
Frizi and
JaroslavTulach
as code owners
kazcw
added
the
CI: No changelog needed
I think this change is necessary, but it doesn't seem to be sufficient: I'm still seeing the original exception, instead of the message attached when rethrowing. |
JaroslavTulach
approved these changes
Sep 20, 2024
| @@ -18,7 +18,7 @@ public static Value getType(String moduleName, String typeName) { | |||
| var ex = | |||
| new NullPointerException( | |||
| "Cannot get type for " + moduleName + " type: " + typeName + " at " + module); | |||
| ex.initCause(ex); | |||
| ex.initCause(e); | |||
There was a problem hiding this comment.
Oh, thanks for the catch.
| byte[] inputBytes = input.toString().getBytes(StandardCharsets.UTF_8); | ||
| ByteBuffer inputBuf = ByteBuffer.allocateDirect(inputBytes.length); | ||
| inputBuf.put(inputBytes); | ||
| return parseTreeLazy(state, inputBuf); | ||
| } | ||
|
|
||
| public Tree parse(CharSequence input) { | ||
| var state = getState(); |
There was a problem hiding this comment.
Ok, this kind of robustness check cannot hurt.
hubertp
approved these changes
Sep 20, 2024
GregoryTravis
approved these changes
Sep 20, 2024
jdunkerley
pushed a commit
that referenced
this pull request
Sep 26, 2024
- Fix debug logging for #11088 case--attempt to create an exception that is its own cause fails. - In case the parser is used after closing, throw an `IllegalStateException` instead of UB. (This case is not known to occur and doesn't seem to be behind the #11121, but we should handle it more safely if it does.) (cherry picked from commit e587d56)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
IllegalStateExceptioninstead of UB. (This case is not known to occur and doesn't seem to be behind the Parser crashing in native code due to multi-threaded access #11121, but we should handle it more safely if it does.)Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.