Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow numbers starting with dot in WidgetNumber #11108

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Allow numbers starting with dot in WidgetNumber #11108

merged 3 commits into from
Sep 17, 2024

Conversation

farmaazon
Copy link
Contributor

Pull Request Description

Screencast.from.2024-09-17.13-20-40.webm

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • [ ] The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • [ ] Unit tests have been written where possible.

@farmaazon farmaazon added x-new-feature Type: new feature request -gui labels Sep 17, 2024
@farmaazon farmaazon self-assigned this Sep 17, 2024
@farmaazon farmaazon added the CI: Ready to merge This PR is eligible for automatic merge label Sep 17, 2024
@mergify mergify bot merged commit 5725e24 into develop Sep 17, 2024
36 checks passed
@mergify mergify bot deleted the wip/farmaazon/allow-numbers-starting-with-dot branch September 17, 2024 13:07
jdunkerley pushed a commit that referenced this pull request Sep 17, 2024
@farmaazon @jdunkerley
Allow numbers starting with dot in WidgetNumber (#11108)
5c4fe1b 
[Screencast from 2024-09-17 13-20-40.webm](https://github.com/user-attachments/assets/561adebb-7d93-4939-9dde-5453d5f304be)

(cherry picked from commit 5725e24)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frizi Frizi Frizi approved these changes

@vitvakatu vitvakatu Awaiting requested review from vitvakatu vitvakatu is a code owner

@kazcw kazcw Awaiting requested review from kazcw kazcw is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

Assignees

@farmaazon farmaazon

Labels
-gui CI: Ready to merge This PR is eligible for automatic merge x-new-feature Type: new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@farmaazon @Frizi @jdunkerley